Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "feat(locksmith): Add pdf format for ticket and certificates"" #13667

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Revert "Revert "feat(locksmith): Add pdf format for ticket and certificates"" #13667

wants to merge 2 commits into from

Conversation

julien51
Copy link
Member

Reverts #13666

@cla-bot cla-bot bot added the cla-signed label Apr 23, 2024
@julien51
Copy link
Member Author

This needs more testing on staging and some debugging as well.

SVell
SVell approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@SVell SVell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was it originally reverted?

@searchableguy
Copy link
Contributor

There is a an issue with svg-to-pdf kit with rendering inline embedded images which is a blocker for this. We would need to find a work around.

@julien51 julien51 requested review from 0xTxbi and SVell and removed request for 0xTxbi and SVell August 29, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SVell SVell SVell approved these changes

@0xTxbi 0xTxbi Awaiting requested review from 0xTxbi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julien51 @searchableguy @SVell