Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/badges places and secu role #256

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Conversation

Suboyyy
Copy link
Contributor

@Suboyyy Suboyyy commented Oct 31, 2024

Badges places and secu role

Changes

  • Add places on badge's back
  • Add firstAid logo on badges if permission firstaid

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Porblème de lint, sinon c good

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.11%. Comparing base (522ad3c) to head (ddea2b7).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/utils/badge.ts 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #256      +/-   ##
==========================================
- Coverage   95.20%   95.11%   -0.09%     
==========================================
  Files         121      121              
  Lines        2813     2824      +11     
  Branches      423      425       +2     
==========================================
+ Hits         2678     2686       +8     
- Misses        104      106       +2     
- Partials       31       32       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Suboyyy Suboyyy merged commit 7159b7e into dev Oct 31, 2024
6 checks passed
@Suboyyy Suboyyy deleted the feat/badges-places-and-secu-role branch October 31, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants