Merge master #253
Merged
Merge master #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: adding test for createCart (user) * Update createCart.test.ts * fix: seems to be good * fix: respo ssl not full access * feat: vieux are invite * fix: invite does not exist in this branche --------- Co-authored-by: Antoine D <[email protected]>
feat: discordID in superSearch
* feat: create majority filter (#238) Co-authored-by: Antoine D <[email protected]> Co-authored-by: Remi-pcn <[email protected]> * fix: plus d'info sensible quand on cherche /api/teams/:teamID * fix: changed filter * fix: badge in descending order --------- Co-authored-by: Antoine D <[email protected]> Co-authored-by: Antoine D <[email protected]>
* feat: custom badge don't anymore call database (fullcustom), badges don't match with permissions * feat: change environments variables, badge image must be in base64 * feat: all images are now in .env * fix: removed badge background from files * fix: add default images * fix: badgePermission type can be invite * fix: badge base64 webp support * fix: remove all async (lint) * fix: env working for tests * feat: vieux are now invite * fix: env test on ci * fix: lint * fix: modify single custom badge test * fix: lint --------- Co-authored-by: Antoine D <[email protected]> Co-authored-by: Noé Landré <[email protected]> Co-authored-by: Antoine D <[email protected]>
* fix: refactor badge.ts to use volume system for image loading * fix: lint * fix: update env --------- Co-authored-by: Antoine D <[email protected]>
tuturd
requested changes
Oct 10, 2024
tuturd
reviewed
Oct 10, 2024
tuturd
reviewed
Oct 10, 2024
Co-authored-by: Antoine D <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 94.91% 95.11% +0.20%
==========================================
Files 121 121
Lines 2812 2825 +13
Branches 426 425 -1
==========================================
+ Hits 2669 2687 +18
+ Misses 107 106 -1
+ Partials 36 32 -4 ☔ View full report in Codecov by Sentry. |
* refactor: remove unused badge environment variables * refactor: remove unused commissionRole field in generateBadges.test.ts * fix: update text color in generateBadge function * fix: adjust vertical positioning of last name in generateBadge function * feat: add image field to BadgeField interface --------- Co-authored-by: Antoine D <[email protected]>
* refactor: remove unused badge environment variables * refactor: remove unused commissionRole field in generateBadges.test.ts * fix: update text color in generateBadge function * fix: adjust vertical positioning of last name in generateBadge function * feat: add image field to BadgeField interface * feat: add badges to gitignore * fix: text color depending of the badge color (daltonian friendly) * fix: it's better like that --------- Co-authored-by: Antoine D <[email protected]>
Remi-pcn
previously approved these changes
Oct 12, 2024
* feat: orga place on badges (Orgas and single custom generation only) * feat: first-aid logo if firstaid perm + place in database * fix: lint * feat: tests? --------- Co-authored-by: Antoine D <[email protected]>
tuturd
previously approved these changes
Oct 31, 2024
Remi-pcn
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge master
TODO
Changes