Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moved badges background from github to /upload #236

Closed
wants to merge 2 commits into from
Closed

Conversation

Remi-pcn
Copy link
Contributor

PR name

Fix de la security issue des badges sur le notion

Changes

Les backgournds de badges sont maintenant sur l'upload ( normalement ca devrait marcher meme sur la prod mais on pouvait pas vraiment test en local)

Breaking changes

What's left to do (DELTE THIS PART FOR NON-DRAFT PRs)

  • Verify build
  • Lint
  • Remove console.log / commented code

Copy link
Contributor

@Suboyyy Suboyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

met le bon nom et c bon

const loadBackFullAccess = () => `data:image/png;base64,${readFileSync(`assets/badges/back-fullaccess.png`, 'base64')}`;
const loadBackRestricted = () => `data:image/png;base64,${env.front.website}/uploads/files/badges/back-fullaccess.png`;
const loadBackOrgaPrice = () => `data:image/png;base64,${env.front.website}/uploads/files/badges/back-orgaprice.png`;
const loadBackFullAccess = () => `data:image/png;base64,${env.front.website}/uploads/files/badges/ba.png`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nom de l'image chelou

Copy link
Contributor

@Suboyyy Suboyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probleme avec les tests

@tuturd tuturd closed this Oct 3, 2024
@tuturd tuturd deleted the badges branch October 3, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants