Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove position sent to client #176

Merged
merged 3 commits into from
Oct 22, 2023
Merged

Conversation

DevNono
Copy link
Contributor

@DevNono DevNono commented Oct 22, 2023

PR name

Changes

Breaking changes

What's left to do (DELTE THIS PART FOR NON-DRAFT PRs)

  • Verify build
  • Lint
  • Remove console.log / commented code

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ce9c4a) 95.14% compared to head (99c43f0) 95.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #176   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         110      110           
  Lines        2408     2408           
  Branches      340      340           
=======================================
  Hits         2291     2291           
  Misses         75       75           
  Partials       42       42           
Files Coverage Δ
src/controllers/partners/getPartners.ts 100.00% <100.00%> (ø)
src/utils/filters.ts 97.22% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DevNono DevNono merged commit f7cc8b5 into dev Oct 22, 2023
6 checks passed
@DevNono DevNono deleted the remove-position-sent-to-front branch October 22, 2023 22:39
DevNono added a commit that referenced this pull request Sep 10, 2024
* feat: remove position sent to client

* fix: issue

* fix: doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants