Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed crash when caster array was empty #161

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

TeddyRoncin
Copy link
Member

Fix crash when no caster was passed to route PATCH /admin/tournaments/:tournamentId

Changes

Now the request.body.casters is always set to undefined, before it could still be equal to [] after adding casters (if there were none)

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (89a5319) 96.36% compared to head (6cae626) 96.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #161   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files         110      110           
  Lines        2338     2338           
  Branches      333      333           
=======================================
  Hits         2253     2253           
  Misses         47       47           
  Partials       38       38           
Files Coverage Δ
.../controllers/admin/tournaments/updateTournament.ts 95.83% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DevNono DevNono merged commit 317507b into dev Oct 17, 2023
6 checks passed
@DevNono DevNono deleted the fix/update-tournament branch October 17, 2023 19:06
DevNono pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants