Fix/tests not passing pr135 #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: when a cart is paid, refunded or forced paid, teams can be locked or unlocked
…re is no place left fix: there was a problem when fetching player tickets in updateCart() operation
* added tests for route POST /etupay/callback * removed tests for route POST /teams/current/lock
* added the tests * fixed a bug where a team could be not full but force pay would still lock it (or put it on the waiting list)
* fixed some typos in the name of the tests of the file etupay/callback.test.ts * added some await at the end of a test to make sure instructions have finished running
* added tests * fixed a bug in file operations/carts.ts where the check of the name of the item was done wrong
* added tests * changed signature of the kickUser method : it now takes the user and not only its id * fixed a bug where any type of members made the team be unlocked when they were kicked / they left * route DELETE /teams/current/users/current no longer needs the team to not be locked
* added tests * route DELETE /teams/current/users/:userId no longer needs the team to not be locked
* added tests * the team can now be locked to make the request (it will still return an error tho, but not due to the fact that it is locked, but instead that it is full) * fixed bugs with the remake of functions kickUser and joinTeam (in the team operations file)
* added tests * team can now be locked to delete it * a team that is locked and deleted now lets its place to a team in the waiting list
* removed the middleware isTeamNotLocked, and its usages * removed the tests that tested that middleware
* added tests to verify a team in the queue would be moved to the locked teams if necessary with routes : - DELETE /teams/current/users/:userId - DELETE /teams/current/users/current - POST /admin/carts/:cartId/refund
* linted code * for operation imports : replaced single function imports by gobal imports
* team can now be locked OR in the queue * added test for that
* a test was not passing because there was neither casters nor cashprizes on the tournaments
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #142 +/- ##
==========================================
+ Coverage 96.45% 96.67% +0.21%
==========================================
Files 108 107 -1
Lines 2231 2257 +26
Branches 317 324 +7
==========================================
+ Hits 2152 2182 +30
+ Misses 42 40 -2
+ Partials 37 35 -2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this one, it only exists for debug purposes, see PR#135
Changements
Breaking changes
Ce qu'il reste à faire (POUR LES DRAFTS)