fix: fields format and infos of `PATCH /admin/tournaments/:tournament…

…Id` can now be empty strings (#227)
ungdev · Sep 5, 2024 · b2cf44f · b2cf44f
1 parent de0d447
commit b2cf44f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/controllers/admin/tournaments/updateTournament.ts b/src/controllers/admin/tournaments/updateTournament.ts
@@ -15,10 +15,10 @@ export default [
       name: Joi.string().optional(),
       maxPlayers: Joi.number().optional(),
       cashprize: Joi.number().optional(),
-      cashprizeDetails: Joi.string().optional(),
+      cashprizeDetails: Joi.string().allow('').optional(),
       displayCashprize: Joi.boolean().optional(),
-      format: Joi.string().optional(),
-      infos: Joi.string().optional(),
+      format: Joi.string().allow('').optional(),
+      infos: Joi.string().allow('').optional(),
       casters: Joi.array().items(Joi.string()).optional(),
       displayCasters: Joi.boolean().optional(),
       display: Joi.boolean().optional(),

diff --git a/tests/admin/tournaments/updateTournament.test.ts b/tests/admin/tournaments/updateTournament.test.ts
@@ -192,4 +192,12 @@ describe('PATCH /admin/tournaments/{tournamentId}', () => {
     const tournamentDatabase = await tournamentOperations.fetchTournament(tournament.id);
     expect(tournamentDatabase.maxPlayers).to.equal(validBody.maxPlayers);
   });
+
+  it('should allow for empty strings in fields `format` and `infos`', async () => {
+    await request(app)
+      .patch(`/admin/tournaments/${tournament.id}`)
+      .send({ format: '', infos: '' })
+      .set('Authorization', `Bearer ${adminToken}`)
+      .expect(200);
+  });
 });