Merge pull request #179 from ungdev/dev

small change in tournament and partners positions
ungdev · Oct 23, 2023 · a6dd213 · a6dd213
2 parents e728c3b + d258668
commit a6dd213
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 11 deletions.
diff --git a/src/controllers/openapi.yml b/src/controllers/openapi.yml
@@ -93,8 +93,6 @@ components:
         placesLeft:
           type: integer
           example: 5
-        position:
-          type: integer
 
     UserRestricted:
       type: object
@@ -758,8 +756,6 @@ components:
         discordVocalCategoryId:
           type: string
           nullable: true
-        position:
-          type: integer
         teams:
           type: array
           items:
@@ -776,8 +772,6 @@ components:
           type: string
         display:
           type: boolean
-        position:
-          type: integer
 
   responses:
     400Errored:

diff --git a/src/controllers/partners/getPartners.ts b/src/controllers/partners/getPartners.ts
@@ -14,7 +14,7 @@ export default [
       result = result.filter((partner) => partner.display);
 
       // Don't pick the display field
-      const partners = result.map((partner) => pick(partner, ['id', 'name', 'link', 'position']));
+      const partners = result.map((partner) => pick(partner, ['id', 'name', 'link']));
 
       return success(response, partners);
     } catch (error) {

diff --git a/src/utils/filters.ts b/src/utils/filters.ts
@@ -166,7 +166,6 @@ export const filterTournamentRestricted = (tournament: Tournament) => {
     'cashprizeDetails',
     'format',
     'infos',
-    'position',
   );
 
   return {

diff --git a/tests/partners/getPartners.test.ts b/tests/partners/getPartners.test.ts
@@ -56,7 +56,7 @@ describe('GET /partners', () => {
     expect(response.body).to.have.lengthOf(partners.length - 1);
     // Not to have tournaments[0] because it has display false
     expect(response.body).not.to.have.deep.members([partners[0]]);
-    expect(response.body[0]).to.have.all.keys(['id', 'name', 'link', 'position']);
+    expect(response.body[0]).to.have.all.keys(['id', 'name', 'link']);
     expect(response.body[0].name).to.be.a('string');
     expect(response.body[0].link).to.be.a('string');
   });

diff --git a/tests/tournaments/getTournaments.test.ts b/tests/tournaments/getTournaments.test.ts
@@ -75,7 +75,6 @@ describe('GET /tournaments', () => {
       'infos',
       'format',
       'cashprizeDetails',
-      'position',
     ]);
     expect(response.body[0].lockedTeamsCount).to.be.a('number');
     expect(response.body[0].cashprize).to.be.a('number');
@@ -114,7 +113,6 @@ describe('GET /tournaments', () => {
       'infos',
       'format',
       'cashprizeDetails',
-      'position',
     ]);
     expect(response.body[1].lockedTeamsCount).to.be.a('number');
     expect(response.body[0].cashprize).to.be.null;