Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V15: Show a loader during the login procedures rather than oddly styled content #17618

Open
wants to merge 4 commits into
base: v15/dev
Choose a base branch
from
Open

V15: Show a loader during the login procedures rather than oddly styled content #17618

wants to merge 4 commits into from

Conversation

iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Nov 22, 2024 •
edited
Loading

Description

Fixes #17453

  • Shows only a loader for a normal login flow
  • Shows the umb-app-error component only if the flow fails (either in the main window or a popup)
  • Fixes an error where hasOwnOpener did not work (at least not on the Vite server)

How to test

  1. Log in as normal and verify that you do not see a "flash of oddly styled content"
  2. Try and force a session timeout, e.g. by changing the access_token in Local Storage and perform some kind of request, e.g. go to a content page
  3. You should now see the login timeout overlay
  4. Verify that the popup is closed after login and that you only see a loader inside the popup

Hint: You can force the "login landing page" by going to /oauth_complete in the browser. Append ?code=test to see the success variant and omit the ?code parameter to see the failure variant.

@iOvergaard
feat: show only a loader on a default login flow
26f1734 
if the flow fails, the app-error component will be shown, or if the flow is initialised inside a popup (i.e. the session was lost)
@iOvergaard
fix: hasOwnOpener did not recognize the local vite url as its own pat…
a352e9d 
…hname

it should work better by checking the `startsWith` comparing the pathname, and besides, it seems to work better for the understanding of the function to inverse the true/false check
@iOvergaard iOvergaard changed the title v15/feature/login-default-flow V15: Show a loader during the login procedures rather than oddly styled content Nov 22, 2024
@iOvergaard iOvergaard mentioned this pull request Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher Awaiting requested review from leekelleher

Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iOvergaard