Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V15: bugfix: Prevent navigating to non folders/media without children in media picker #17617

Open
wants to merge 23 commits into
base: v15/dev
Choose a base branch
from

handle start node in breadcrumb

5bbfd3b
Select commit
Loading
Failed to load commit list.
Open

V15: bugfix: Prevent navigating to non folders/media without children in media picker #17617

handle start node in breadcrumb
5bbfd3b
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev) succeeded Nov 22, 2024 in 34s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.17 (10.00 -> 9.83)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional media-picker-modal.element.ts: UmbMediaPickerModalElement.renderBreadcrumb

Annotations

Check warning on line 323 in src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/media-picker-modal.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Conditional 

UmbMediaPickerModalElement.renderBreadcrumb has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
View more details on CodeScene Delta Analysis