-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new suite of bootstrap current scalings #3355
Implement new suite of bootstrap current scalings #3355
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3355 +/- ##
==========================================
+ Coverage 27.11% 27.13% +0.01%
==========================================
Files 77 77
Lines 17816 17921 +105
==========================================
+ Hits 4831 4862 +31
- Misses 12985 13059 +74 ☔ View full report in Codecov by Sentry. |
- Add calculation of volume averaged pressure in plasma_profiles.md. This also add the core pressure and volume averaged pressure to the output. Assuming a parabolic profile - Implement bootstrap fraction calculation using Andrade et al formula in physics.py. This is currently implemented and exported with no tests and notes of applicability regimes
- Add calculation of volume averaged pressure in plasma_profiles.md. This also add the core pressure and volume averaged pressure to the output. Assuming a parabolic profile - Implement bootstrap fraction calculation using Andrade et al formula in physics.py. This is currently implemented and exported with no tests and notes of applicability regimes
54c4cb3
to
9e57e4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a look at the docs files and plot_proc, there are some changes throughout
documentation/proc-pages/physics-models/plasma_current/bootstrap_current.md
Outdated
Show resolved
Hide resolved
documentation/proc-pages/physics-models/plasma_current/bootstrap_current.md
Outdated
Show resolved
Hide resolved
documentation/proc-pages/physics-models/plasma_current/bootstrap_current.md
Outdated
Show resolved
Hide resolved
documentation/proc-pages/physics-models/plasma_current/bootstrap_current.md
Outdated
Show resolved
Hide resolved
documentation/proc-pages/physics-models/plasma_current/bootstrap_current.md
Outdated
Show resolved
Hide resolved
…ap_current.md Co-authored-by: Jonathan Matthews <[email protected]>
…ap_current.md Co-authored-by: Jonathan Matthews <[email protected]>
…ap_current.md Co-authored-by: Jonathan Matthews <[email protected]>
…ap_current.md Co-authored-by: Jonathan Matthews <[email protected]>
…ap_current.md Co-authored-by: Jonathan Matthews <[email protected]>
… bootstrap comparison
@kj5248 Changes pushed, please check again |
Covered in CITATION.cff and README.md.
* allow process version to be printed to terminal * add version monkeypatch to test_run_mode
7757b49
to
9baa160
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single thing, otherwise I believe it is all good
…ore to volume averaged value ratio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment regarding profile assumptions. Feel free to merge if you dont think its a problem.
This pull request includes several updates to the documentation and codebase, primarily focusing on the addition of new bootstrap current scaling methods and improvements to plotting functions.
Documentation Updates:
Codebase Improvements:
plt
methods for better encapsulation.plot_bootstrap_comparison
to generate a comparison plot of bootstrap current fractions using various scaling methods.main_plot
andmain
functions to include the new bootstrap comparison plot.main_plot
function comment.Plasma Profiles:
calculate_profile_factors
.This pull request includes significant updates to the documentation and codebase, particularly focusing on the bootstrap current models and plotting functions. The most important changes include the addition of new bootstrap current scaling methods, updates to the plotting functions to use axis objects, and enhancements to the documentation.Documentation Updates:
ARIES
,Andrade
,Hoang
,Wong
,Gi
) and their descriptions inbootstrap_current.md
.Codebase Enhancements:
plot_proc.py
to useaxis
objects instead ofplt
for plotting functions.plot_bootstrap_comparison
to visualize bootstrap current fractions.main_plot
andmain
functions to include the new bootstrap comparison plot.Physics Calculations:
physics
function.outplas
function.Minor Fixes:
plasma_current_MA
toplasma_current_ma
inplot_proc.py
.scipy
inphysics.py
to support new calculations.Checklist
I confirm that I have completed the following checks: