Fix : React DND broken when used within a NodeViewWrapper (#5023)

* Fix : React DND broken when used within a NodeViewWrapper * added changeset --------- Co-authored-by: Tejendra Singh <[email protected]> Co-authored-by: Dominik Biedebach <[email protected]>
ueberdosis · Dec 2, 2024 · b7ef150 · b7ef150
1 parent 722ec00
commit b7ef150
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/stupid-shrimps-speak.md b/.changeset/stupid-shrimps-speak.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/core": patch
+---
+
+Fixed an issue with nodeviews preventing any drag events in child nodes of the nodeview wrapper element
diff --git a/packages/core/src/NodeView.ts b/packages/core/src/NodeView.ts
@@ -151,11 +151,11 @@ export class NodeView<
     // ProseMirror tries to drag selectable nodes
     // even if `draggable` is set to `false`
     // this fix prevents that
-    if (!isDraggable && isSelectable && isDragEvent) {
+    if (!isDraggable && isSelectable && isDragEvent && event.target === this.dom) {
       event.preventDefault()
     }
 
-    if (isDraggable && isDragEvent && !isDragging) {
+    if (isDraggable && isDragEvent && !isDragging && event.target === this.dom) {
       event.preventDefault()
       return false
     }