Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 590: Change AlternateDataStream parent class to FileSystemObject #605

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Issue 590: Change AlternateDataStream parent class to FileSystemObject #605

merged 4 commits into from
Jun 17, 2024

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented May 10, 2024 •
edited
Loading

This Pull Request resolves all backwards-incompatible requirements of Issue #590 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop-2.0.0
  • CI passes in UCO current unstable-2.0.0 branch (17ec4f6)
  • CI passes in CASE current unstable-2.0.0 branch tracking UCO's unstable-2.0.0 as submodule (ffe5a73)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora (N/A)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Milestone linked
  • PR 604 merged
  • PR 608 merged
  • Solutions Approval vote logged on corresponding Issue

@ajnelson-nist
Merge branch 'BugFix-Issue-590' into BugFix-Issue-590-2.0.0
7c8d8cb
@ajnelson-nist
Change AlternateDataStream parent class to FileSystemObject
d344226 
A follow-on patch will regenerate Make-managed files.

References:
* #590

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist
Regenerate Make-managed files
ec62648 
References:
* #590

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist added this to the UCO 2.0.0 milestone May 10, 2024
@ajnelson-nist ajnelson-nist linked an issue May 10, 2024 that may be closed by this pull request
observable:AlternateDataStream is not a subclass of FileSystemObject, but File and ReparsePoint are #590
Closed
14 tasks
@ajnelson-nist ajnelson-nist mentioned this pull request May 10, 2024
Closed
14 tasks
@ajnelson-nist
Copy link
Contributor Author

This PR is ready for review and merge.

@ajnelson-nist ajnelson-nist marked this pull request as ready for review June 12, 2024 19:57
@ajnelson-nist ajnelson-nist requested a review from a team June 17, 2024 13:31
@plbt5 plbt5 merged commit 6591982 into develop-2.0.0 Jun 17, 2024
1 check passed
@plbt5 plbt5 deleted the BugFix-Issue-590-2.0.0 branch June 17, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
Change Proposal
Projects
None yet
Milestone
UCO 2.0.0
Development

Successfully merging this pull request may close these issues.

observable:AlternateDataStream is not a subclass of FileSystemObject, but File and ReparsePoint are
2 participants
@ajnelson-nist @plbt5