Version 1.1 -> 1.2 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated CHANGELOG.md and README.md
Modified src/validator.py as follows:
To flag ordered lists (olo) as UnsupportedFeature instead of random bnode errors.
To flag properties not in the ontology as unknown property
Version 1.1 assumed an open model, where unknown properties are acceped as unconstrained.
Version 1.2 uses a less-open model, where
properties not in the ontology are rejected
properties not known to the class (but known to the ontology) are accepted as constrained.
In validator.py, replaced startswith(XSD) with startswith(str(XSD)). This bug has already been fixed in the UCO github.
In precondition.py, replaced len(alphabet) with len(alphabet)**prefix_length. This is a new bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated CHANGELOG.md and README.md
Modified src/validator.py as follows:
To flag ordered lists (olo) as UnsupportedFeature instead of random bnode errors.
To flag properties not in the ontology as unknown property
Version 1.1 assumed an open model, where unknown properties are acceped as unconstrained.
Version 1.2 uses a less-open model, where
properties not in the ontology are rejected
properties not known to the class (but known to the ontology) are accepted as constrained.