-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component Interactions, Remote CLI improvements. #336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and temp debug changes for remote cli invoke and tests.
…ht buffer time, introduce invoke remote cli function, enhanced the (data collect, log_sync, manage_deployments, run_deployment_migrator, and remove_workflow) client cli to be able to use the remote cli, expanded iam policy for remote_cli for remote function, implemented component interations for all applicable operations, added z_standard to deployment packager reprequisites, removing workflow also removes deployment manager workflow info entry, removing deployment manager resource is now at the end such that if removal of workflow fails it still appears in list workflow for retry deletion, cleaned up log syncer get time intervals, many other misc changes.
Danidite
changed the title
Component Interactions, Many Misc Fixes and Changes
Component Interactions, many miscellaneous fixes and improvements.
Oct 29, 2024
…te_cli doc, added warning regarding experimental nature of remote cli.
Danidite
changed the title
Component Interactions, many miscellaneous fixes and improvements.
Component Interactions, Remote CLI improvements.
Oct 31, 2024
vGsteiger
approved these changes
Nov 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comments but these can also be follow up issues. I don't see any critical issues since most is tested and the changes are 80% cosmetic. Thanks!
caribou/deployment_solver/deployment_metrics_calculator/models/workflow_instance.py
Show resolved
Hide resolved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component interactions and general remote CLI improvements.
Addresses the following issues:
Other minor changes: