Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version bump + improvements to svg2pdf #52

Merged
merged 59 commits into from
Jan 24, 2024
Merged

Version bump + improvements to svg2pdf #52

merged 59 commits into from
Jan 24, 2024

Conversation

LaurenzV
Copy link
Collaborator

This PR:

  • Bumps to resvg 0.38. It contains quite a few changes wrt how bboxes are handled, but also the resvg API itself. But these changes are what enable us to easily add filters in the first place.
  • Adds support for filters (only a few edge cases are not working correctly yet because they are a bit difficult to handle). The resolution of filters can be changed via a setting (which means it could in theory also be controlled from Typst)
  • Improves clip paths with non zero winding rule
  • Fixes Wavedrom diagram rendering issues (font, dotted lines) #46

LaurenzV and others added 30 commits December 10, 2023 18:33
@LaurenzV
Make cli default member
5bf1fcc
@LaurenzV
Nearly working
4955bc4
@LaurenzV
Fix bug with bounding box
dd8bbee
@LaurenzV
Fix text in clip paths
b88ec50
@LaurenzV
Make clippy happy
014293d
@LaurenzV
make cargo fmt happy
b5e931f
@LaurenzV
Bump versions
b707bb0
@LaurenzV
Disable default features again
46b198a
@LaurenzV
Make it compile
8fac820
@LaurenzV
Fix some issues
81407fa
@LaurenzV
Fix order
2da3a88
@LaurenzV
Format
bd1d090
@LaurenzV
Fix path issue
220eb87
@LaurenzV
Add bounds check for stroke
df8ad0c
@LaurenzV
Update reference images
91da8e3
@LaurenzV
extract bbox into custom method
a3a8f40
@LaurenzV
Add stroke with opacity 0 test
be0b3f2
@LaurenzV
Moar tests
e01b356
@LaurenzV
First brittle attempt at filters
45fdb05
@LaurenzV
Regenerate test files and remove undefined behavior ones.
3305328
@LaurenzV
Remove reference images that fail on resvg
2043cba
@LaurenzV
Add support for setting scale of raster effects via options
e3c7eee
@LaurenzV
Change to float values for raster effects
ee14034
@LaurenzV
Update reference images
520bde7
@LaurenzV
Temporary workaround to make test cases work
800757f
@LaurenzV
Correct implementation of filters
d0f3381
@LaurenzV
Extract filter into its own crate and create a feature
6078e2c
@LaurenzV
Add comments + format
bf98116
@LaurenzV
Remove wrong test cases
1d39f56
@LaurenzV
Optimize imports
0dead70
LaurenzV and others added 24 commits December 22, 2023 10:58
@LaurenzV
Prettify filter code a bit
330ce28
@LaurenzV
Update some comments
89fdd13
@LaurenzV
Add transform origin tests
a9ad1b9
@LaurenzV
Sync paint-order tests
797d79a
@LaurenzV
Sync text tests
e326529
@LaurenzV
Sync text tests
77f9087
@LaurenzV
Format
e103e29
@LaurenzV
Update readme
082015e
@LaurenzV
First working version of new resvg
4d1ac87
@LaurenzV
Second update
f3d6cc3
@LaurenzV
Fix bug with applying transformation
3c0bb9d
@LaurenzV
Update how transform is stored
3b2b8d0
@LaurenzV
Provide temporary workaround for filter problem
cff0cf1
@LaurenzV
Update tests
d6f5262
@LaurenzV
More working tests!
8ca82e2
@LaurenzV
Improve clip path handling for evenodd
2b8b2bd
@LaurenzV
Set not dashed line explicitly
2cf32de
@LaurenzV
version bump
4067199
@LaurenzV
Merge branch 'main-upstream' into filters
0c9f162 
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	cli/src/main.rs
#	src/render/clip_path.rs
#	src/render/mod.rs
#	src/render/path.rs
#	src/util/helper.rs
@LaurenzV
merge
7cfa697
@LaurenzV
Render group normally without filter if feature is disabled
6562a7e
@LaurenzV
Format + clippy
cf8bd18
@LaurenzV
clippy
0531699
@LaurenzV
Stoooooooop
ee42a22
@reknih
Copy link
Member

reknih commented Jan 24, 2024

Thank you for taking this into your own hands! You can also remove Filters from the unsupported features list in the README file :)

@LaurenzV
Copy link
Collaborator Author

Didn't I already do that? 🤔

@reknih
Copy link
Member

reknih commented Jan 24, 2024

Oh my bad!

@reknih
Copy link
Member

reknih commented Jan 24, 2024

Thank you so much!

@reknih reknih merged commit 49891ef into typst:main Jan 24, 2024
2 checks passed
@LaurenzV LaurenzV deleted the filters branch January 24, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wavedrom diagram rendering issues (font, dotted lines)
2 participants
@LaurenzV @reknih