Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade @vue/language-core #51

Merged
merged 2 commits into from
Sep 5, 2024
Merged

fix: upgrade @vue/language-core #51

merged 2 commits into from
Sep 5, 2024

Conversation

antfu
Copy link
Member

@antfu antfu commented Sep 1, 2024

There was a breaking change in @vue/language-core v2.1, Twoslsash v0.2.10 locked it in patch range in 2ce57ba as an temporary workaround.

This PR is trying to upgrade the language tool but got runtime errors.

/cc @johnsoncodehk, do you have any clue how to fix this? Thank you

@antfu antfu marked this pull request as draft September 1, 2024 16:24
Copy link

netlify bot commented Sep 1, 2024

Deploy Preview for twoslash ready!

Name Link
🔨 Latest commit f2fa396
🔍 Latest deploy log https://app.netlify.com/sites/twoslash/deploys/66d9d6d965ee6300086b416c
😎 Deploy Preview https://deploy-preview-51--twoslash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KazariEX
Copy link

KazariEX commented Sep 1, 2024

const fileCompiled = get(sourceScript.generated!.embeddedCodes.values(), 1)!

Change the second parameter to 2, and I will fix the rest in @vue/language-core.

@zhiyuanzmj
Copy link
Contributor

zhiyuanzmj commented Sep 5, 2024

Already fixed #53

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.82%. Comparing base (2e3d85f) to head (f2fa396).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files          16       16           
  Lines        1490     1491    +1     
  Branches      350      348    -2     
=======================================
+ Hits         1398     1399    +1     
  Misses         92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antfu antfu marked this pull request as ready for review September 5, 2024 16:10
@antfu antfu changed the title fix: try upgrade @vue/language-core fix: upgrade @vue/language-core Sep 5, 2024
@antfu antfu merged commit 8801060 into main Sep 5, 2024
11 checks passed
@antfu antfu deleted the feat/vue-language-core branch September 5, 2024 16:10
@antfu
Copy link
Member Author

antfu commented Sep 5, 2024

Thanks @zhiyuanzmj @KazariEX!

@sxzz
Copy link

sxzz commented Sep 6, 2024

@antfu Could you please release a new version for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants