-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade @vue/language-core
#51
Conversation
✅ Deploy Preview for twoslash ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
twoslash/packages/twoslash-vue/src/index.ts Line 146 in 8226ef8
Change the second parameter to |
Already fixed #53 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage 93.82% 93.82%
=======================================
Files 16 16
Lines 1490 1491 +1
Branches 350 348 -2
=======================================
+ Hits 1398 1399 +1
Misses 92 92 ☔ View full report in Codecov by Sentry. |
@vue/language-core
@vue/language-core
Thanks @zhiyuanzmj @KazariEX! |
@antfu Could you please release a new version for it? |
There was a breaking change in
@vue/language-core
v2.1, Twoslsash v0.2.10 locked it in patch range in 2ce57ba as an temporary workaround.This PR is trying to upgrade the language tool but got runtime errors.
/cc @johnsoncodehk, do you have any clue how to fix this? Thank you