New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[draft] THP #4050

Draft

M1nd3r wants to merge 33 commits into main from M1nd3r/thp

Contributor

M1nd3r commented Jul 22, 2024

No description provided.

M1nd3r requested a review from onvej-sl

July 22, 2024 11:42

github-actions bot commented Jul 22, 2024 •

edited

Loading

core UI changes	device test	click test	persistence test
T2T1 Model T	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
T3B1 Safe 3	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
T3T1 Safe 5	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
All	main(screens)

M1nd3r self-assigned this

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/received_message_handler.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/received_message_handler.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/cpace.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/channel.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/pairing_context.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/channel.py Outdated Show resolved Hide resolved

Contributor

onvej-sl commented Jul 26, 2024

Well done, @M1nd3r !

I reviewed the usage of cryptography and compliance with our documentation of the secure channel layer.

M1nd3r force-pushed the M1nd3r/thp branch from e402934 to 98c4f11 Compare

October 10, 2024 10:44

github-actions bot commented Oct 10, 2024 •

edited

Loading

legacy UI changes	device test(screens) main(screens)

M1nd3r changed the title ~~[draft] Review of cryptography in the new THP~~ [draft] THP

M1nd3r force-pushed the M1nd3r/thp branch 11 times, most recently from db0881c to 641611b Compare

November 19, 2024 19:24

M1nd3r force-pushed the M1nd3r/thp branch from 641611b to 39062a7 Compare

November 20, 2024 14:26

M1nd3r added 29 commits

November 22, 2024 09:44


          fixup! refactor(core): abstract cache and context [no changelog]

b218b53


          fixup! chore(core): update core to reflect cache and context refactor…

6116ee2

… [no changelog]


          fixup! fixup! chore(core): update core to reflect cache and context r…

0dc3f50

…efactor [no changelog]


          fixup! test(core): update tests to reflect cache refactor [no changelog]

c7b874d


          test(core): add setUpClass and tearDownClass to core unit tests

0361a69

[no changelog]


          test(core): replace __init__ in unit tests with setUpClass and tearDo…

e022eca

…wnClass

[no changelog]


          fixup! test(core): add setUpClass and tearDownClass to core unit test…

46ad9e7

…s [no changelog]


          feat: implement THP

968c0aa


          test: try fix screen_recording

470a1d6


          temporary disabling of appdirs variables

9f76c29


          fixup! temporary disabling of appdirs variables

2ede529


          fix: remove unused ignores

05bb4ff


          fix: try fix ci tests

b2a999d


          fix: remove appdirs from pyproject.toml

56ee25b


          fix: add newline to the end of poetry.lock

3e45964


          fix: fix protobuf trailing whitespaces

ba3a61d


          fix: remove trailing whitespaces sconscripts

924177a


          fixup: fix unit tests

c10cfee


          fixup base.py style

d3a4adb


          refactor(python): rename NewTrezorConnection to TrezorConnection

255febd

[no changelog]


          fix(python): fix list devices session resumption

12b9b87

[no changelog]


          feat(python): delete channel_data.json when clearing all channels

79b6c2a

[no changelog]


          chore(core): fix core Makefile style'

9379aa4

[no changelog]


          feat(python): rework channel database

ddbf2bc

[no changelog]


          fixup! feat(python): rework channel database [no changelog]

e2973dc


          chore(legacy): add options (max_size) to updated debug messages

9ecea50

[no changelog]


          fix: try to fix emu.py

ff503eb


          fix: try fix fido2-test

5a01ffa

[no changelog]


          fix(python): protocol_v2 database init

[no changelog]

M1nd3r force-pushed the M1nd3r/thp branch from b6fd98b to 4091658 Compare

November 22, 2024 12:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

onvej-sl onvej-sl left review comments

prusnak Awaiting requested review from prusnak prusnak will be requested when the pull request is marked ready for review prusnak is a code owner

matejcik Awaiting requested review from matejcik matejcik will be requested when the pull request is marked ready for review matejcik is a code owner

andrewkozlik Awaiting requested review from andrewkozlik andrewkozlik will be requested when the pull request is marked ready for review andrewkozlik is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet