Flash interface refactoring #3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cepetr
requested review from
prusnak,
andrewkozlik and
matejcik
as code owners
TychoVrahe
force-pushed
the
tychovrahe/u5/basic_support
branch
from
e7fee67
to
b66856a
Compare
cepetr
force-pushed
the
cepetr/u5/flash-refactor
branch
2 times, most recently
from
1641d98
to
c4d508e
Compare
cepetr
added
T3T1
core
TychoVrahe
force-pushed
the
tychovrahe/u5/basic_support
branch
from
b66856a
to
8d78b28
Compare
cepetr
force-pushed
the
cepetr/u5/flash-refactor
branch
from
c4d508e
to
1e13029
Compare
cepetr
changed the base branch from
tychovrahe/u5/basic_support
to
cepetr/bootargs
TychoVrahe
approved these changes
Nov 13, 2023
cepetr
force-pushed
the
cepetr/bootargs
branch
from
d26260b
to
bb6f9d8
Compare
Base automatically changed from
cepetr/bootargs
to
tychovrahe/u5/basic_support
November 14, 2023 12:32
cepetr
force-pushed
the
cepetr/u5/flash-refactor
branch
4 times, most recently
from
8a6223f
to
1bb4680
Compare
TychoVrahe
force-pushed
the
tychovrahe/u5/basic_support
branch
from
2b714cc
to
dda5b6f
Compare
|
One more thing to solve before merging this into U5 branch: since trustzone initialization refactor has now been merged and the allocation of flash pages between secure/non-secure is no longer only dependent on option bytes, |
cepetr
force-pushed
the
cepetr/u5/flash-refactor
branch
from
1f645a3
to
a74a954
Compare
cepetr
changed the base branch from
tychovrahe/u5/basic_support
to
cepetr/u5/stackprot-refactor
|
@TychoVrahe After our discussion, I've removed the detection of secure and non-secure pages, see a74a954 |
TychoVrahe
approved these changes
Nov 15, 2023
cepetr
force-pushed
the
cepetr/u5/flash-refactor
branch
from
a74a954
to
96ac55b
Compare
cepetr
force-pushed
the
cepetr/u5/stackprot-refactor
branch
from
3f94ef5
to
64508fa
Compare
Base automatically changed from
cepetr/u5/stackprot-refactor
to
tychovrahe/u5/basic_support
November 15, 2023 14:57
[no changelog]
cepetr
force-pushed
the
cepetr/u5/flash-refactor
branch
from
96ac55b
to
1d5f3db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactored the code for handling flash programming/erasing with following goals:
The result is not perfect, and achieving perfection would require deep ploughing, but the refactoring has successfully reduced some technical debt and leaves room for further enhancements and improvements.
The significant change is that
flash_common.hhas been split intoflash_area.handflash_ll.h. All code dealing with flash areas now resides inflash_area.c. HAL drivers for flash implement interface defined inflash_ll.h.