New vendor headers for TS3 #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmilata
approved these changes
Nov 2, 2023
|
I'm gonna go ahead, merge this, and solve later as it doesn't affect release. |
mmilata
force-pushed
the
matejcik/vendor-headers-ts3
branch
from
5ad667c
to
99d2572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plus slightly improved vendor header selection logic in SCons
Please review the generated binaries too. Don't forget that in the poetry shell you can use
toiftool infoandtoiftool show. Use./core/tools/headertool.pyto examine generated headers.This should be merged only after the new vendor headers are signed and the appropriate
_signed_prod.binfiles are added. In the current state builds will fail because these files are missing.