Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): replace View full button text with Show all #3229

Merged
merged 2 commits into from
Aug 28, 2023
Merged

chore(core): replace View full button text with Show all #3229

merged 2 commits into from
Aug 28, 2023

Conversation

grdddj
Copy link
Contributor

@grdddj grdddj commented Aug 23, 2023

Fixes #3191:

  • change button text to Show all

@grdddj grdddj requested a review from prusnak as a code owner August 23, 2023 09:34
@grdddj grdddj requested review from Hannsek and removed request for prusnak August 23, 2023 09:34
@grdddj grdddj self-assigned this Aug 23, 2023
@Hannsek
Copy link
Contributor

Hannsek commented Aug 26, 2023 •
edited
Loading

lgtm

there is some problem in core device test as I cannot see the screens from master?
image

also 6 errors in core device R test? what does it mean?
image

@grdddj grdddj requested a review from matejcik as a code owner August 28, 2023 07:59
@grdddj
Copy link
Contributor Author

grdddj commented Aug 28, 2023

there is some problem in core device test as I cannot see the screens from master? image

No idea here, the pipeline is green otherwise and nothing changed in this flow

also 6 errors in core device R test? what does it mean? image

Error means that UI comparison failed - that is expected, as we changed the button text

@grdddj grdddj merged commit be9b880 into master Aug 28, 2023
8 checks passed
@grdddj grdddj deleted the grdddj/show_all_text branch August 28, 2023 10:09
@bosomt
Copy link

bosomt commented Aug 29, 2023

QA OK

  • Device: Trezor T2T1 2.6.1 regular (revision a8a9727)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hannsek Hannsek Hannsek approved these changes

@matejcik matejcik Awaiting requested review from matejcik

Assignees

@grdddj grdddj

Labels
None yet
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Show all" instead of "view full"
3 participants
@grdddj @Hannsek @bosomt