Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print correct model in print_firmware_version #3227

Merged
merged 1 commit into from
Aug 22, 2023
Merged

print correct model in print_firmware_version #3227

merged 1 commit into from
Aug 22, 2023

Conversation

TychoVrahe
Copy link
Contributor

print correct model in print_firmware_version

@TychoVrahe TychoVrahe self-assigned this Aug 18, 2023
matejcik
matejcik reviewed Aug 18, 2023
View reviewed changes
Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a changelog entry

(use +.fixed to create an entry not linked to an issue)

@prusnak
Copy link
Member

prusnak commented Aug 18, 2023 •
edited
Loading

(use +.fixed to create an entry not linked to an issue)

You still can use the PR number instead, no? (3227.fixed in this case)

@matejcik
Copy link
Contributor

or that, yes. not sure if it adds any value in this case

@TychoVrahe
Copy link
Contributor Author

added the changelog: 640b608

@TychoVrahe TychoVrahe merged commit 1b08be0 into master Aug 22, 2023
8 checks passed
@TychoVrahe TychoVrahe deleted the tychovrahe/model_image/fix branch August 22, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcik matejcik matejcik approved these changes

Assignees

@TychoVrahe TychoVrahe

Labels
None yet
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TychoVrahe @prusnak @matejcik