Secret handling in bootloader #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejcik
force-pushed
the
matejcik/bootloader-secrets
branch
from
2906ba5
to
67c0c10
Compare
|
I actually failed to reproduce #3151 . Will give it another try later today and will see. |
TychoVrahe
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
lgtm but as i am author of most of the changes not sure that counts as much.
- still unable to reproduce Do not enter bootloader menu if user is holding two buttons #3151
- changelog missing for legacy (where just ignoring new protobuf message is added)
- vendorheader generate.sh is getting a bit larger, we might want to consider rewriting it into python on next opportunity
… gen_check [no changelog]
[no changelog]
matejcik
force-pushed
the
matejcik/bootloader-secrets
branch
from
d34166c
to
8aa3e39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinned off #2756 to be merged sooner, before prodtest impl is stabilized.
@TychoVrahe do you think we could quickly fix #3151 also?