nest logger in the proper way #3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way logger is properly nested even when the library is used as submodule (e.g. HWI) see bitcoin-core/HWI#697
matejcik
approved these changes
Aug 3, 2023
achow101
added a commit
to bitcoin-core/HWI
that referenced
this pull request
Aug 16, 2023
75af80b present naming preference (without trailing .log) (fametrano) 324b88e nest loggers in the proper way (fametrano) Pull request description: see also: - Blockstream/Jade#78 - LedgerHQ/ledgercomm#16 - trezor/trezor-firmware#3190 ACKs for top commit: achow101: ACK 75af80b Tree-SHA512: 2044b39680e2683fa0a25d9f50f66f8b204fc0b5685c032caef3ccd36cc255e10ce1676902e82a75d4fc7cacb5ea7b5de51a6839f46de4cc64a5010adf76c712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this way logger is properly nested even when the library is used as submodule (e.g. HWI)
see bitcoin-core/HWI#697