Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): create new Ethereum send flow #3188

Merged
merged 4 commits into from
Sep 4, 2023
Merged

feat(core): create new Ethereum send flow #3188

merged 4 commits into from
Sep 4, 2023

Conversation

grdddj
Copy link
Contributor

@grdddj grdddj commented Jul 31, 2023

Fixes #3169:

  • Ethereum send flow according to new designs

image

@grdddj grdddj removed the request for review from prusnak July 31, 2023 15:06
@grdddj grdddj self-assigned this Jul 31, 2023
@grdddj
Copy link
Contributor Author

grdddj commented Aug 7, 2023

144da07 changes CLOSE buttons in CONFIRM DATA details dialogue to be left_arrow and GO BACK

image

@Hannsek
Copy link
Contributor

Hannsek commented Aug 9, 2023

lgtm

@Hannsek Hannsek requested a review from mmilata August 9, 2023 12:25
mmilata
mmilata reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, please rebase to current master and fix CI failures.

core/embed/rust/src/ui/model_tt/layout.rs Show resolved Hide resolved
core/embed/rust/src/ui/model_tr/layout.rs Outdated Show resolved Hide resolved
@grdddj grdddj force-pushed the grdddj/tr_eth_send branch 2 times, most recently from eb0765d to 0b8c839 Compare September 1, 2023 13:20
@grdddj
Copy link
Contributor Author

grdddj commented Sep 4, 2023

Finally, all the CI is green (had issues with renamed UI test-cases) - from my side, ready for approval and merge

@grdddj grdddj merged commit b17d9da into master Sep 4, 2023
8 checks passed
@grdddj grdddj deleted the grdddj/tr_eth_send branch September 4, 2023 11:50
@Hannsek Hannsek mentioned this pull request Sep 12, 2023
Closed
@bosomt
Copy link

bosomt commented Oct 10, 2023

QA OK

Info:

  • Suite version: desktop 23.10.1 (6c8d061f7305947b0270a2560e4cc65d1f7ded27)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/23.10.1 Chrome/112.0.5615.204 Electron/24.5.1 Safari/537.36
  • OS: MacIntel
  • Screen: 1440x900
  • Device: Trezor T2B1 2.6.2 regular (revision 6e5967a)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

@matejcik matejcik Awaiting requested review from matejcik

Assignees

@grdddj grdddj

Labels
None yet
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

T2B1 design eth send
4 participants
@grdddj @Hannsek @bosomt @mmilata