Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do full update on primitive detach #1738

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

signatenkov
Copy link
Contributor

Type of PR: bugfix

PR checklist:

Overview of change:

if primitive is detached chart will perform full update.

@signatenkov signatenkov changed the title CLL-299: do full update on primitive detach do full update on primitive detach Nov 21, 2024
@signatenkov signatenkov marked this pull request as draft November 21, 2024 12:29
Copy link

github-actions bot commented Nov 21, 2024

size-limit report 📦

Path Size
ESM 42.39 KB (-0.17% 🔽)
ESM createChart 36.33 KB (+0.01% 🔺)
ESM createChartEx 35.04 KB (-0.08% 🔽)
ESM Standalone 43.9 KB (-0.08% 🔽)
Standalone 43.86 KB (+0.03% 🔺)
Plugin: Text Watermark 1.87 KB (0%)
Plugin: Image Watermark 1.68 KB (0%)
Plugin: Series Markers 3.97 KB (0%)
Series: LineSeries 2.54 KB (0%)
Series: BaselineSeries 3.04 KB (0%)
Series: AreaSeries 2.99 KB (0%)
Series: BarSeries 2.14 KB (0%)
Series: CandlestickSeries 2.43 KB (0%)
Series: HistogramSeries 2.19 KB (0%)

@signatenkov signatenkov marked this pull request as ready for review November 21, 2024 12:31
@signatenkov signatenkov self-assigned this Nov 21, 2024
tests/e2e/graphics/test-cases/plugins/detach.js Outdated Show resolved Hide resolved
src/api/series-api.ts Outdated Show resolved Hide resolved
@signatenkov signatenkov merged commit 07dab30 into v5-candidate Nov 22, 2024
11 of 33 checks passed
@signatenkov signatenkov deleted the chart_no_update_on_detach branch November 22, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart isn't updated when primitive is detached using plugins-example
2 participants