Add recall #2518
Add recall #2518
Conversation
…h RecallMetric. Adapt confusionStats and Precision with generalized code.
… rename test function properly in precision.
| pub enum ClassificationConfig { | ||
| Binary { | ||
| threshold: f64, | ||
| class_reduction: ClassReduction, |
There was a problem hiding this comment.
I think I would leave the class reduction out of the config. It is mandatory for all classification types based on the metric anyway, and it's weird that the same field is repeated.
| } | ||
| } | ||
|
|
||
| pub enum ClassificationConfig { |
There was a problem hiding this comment.
The name might be a little too generic. I suggest ClassificationMetricConfig.
|
|
||
| /// Input for classification metrics | ||
| #[derive(new, Debug, Clone)] | ||
| pub struct ClassificationInput<B: Backend> { |
There was a problem hiding this comment.
This is a bit too broad since we have other classification metrics already. Since this is relevant to the confusion statistics computed, I suggest that it is renamed to something like ConfusionStatsInput.
Lmk what you think.
| /// Sets the class reduction method. | ||
| #[allow(dead_code)] | ||
| pub fn with_class_reduction(mut self, class_reduction: ClassReduction) -> Self { | ||
| self.class_reduction = class_reduction; | ||
| self | ||
| } | ||
|
|
There was a problem hiding this comment.
With the suggested change to remove class reduction from the config, I would keep this.
| class_reduction: ClassReduction, | ||
| config: PrecisionConfig, | ||
| config: ClassificationConfig, |
There was a problem hiding this comment.
You forgot the separate class_reduction field. But anyway with the suggested change it would remain 🙂
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
#544
Changes
Create
ClassificationInputandClassificationConfig, generalizations ofPrecisionInputandPrecisionConfigfor any classification task (currently used by precision and recall).Add
RecallMetric.Moved ClassReduction into ClassificationConfig, since i think they belong together.
Testing
Added tests for recall