Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-export] Local browser time config option #664

Open
wants to merge 1 commit into
base: releaseCandidate
Choose a base branch
from

Conversation

dmoruzzi
Copy link

@dmoruzzi dmoruzzi commented Nov 29, 2024

Describe your changes

Add an option to convert UTC time to local browser time for Data Export.

Issue ticket number and link

Issue: #527

Checklist before requesting a review

  • I have read and understand the Contributions section
  • Target branch is releaseCandidate and not master
  • I have performed a self-review of my code
  • I ran the unit tests and my PR does not break any tests
    • TEST data-export fails with the current edition of the releaseCandidate. My changes did not contribute to any new failures.
  • I documented the changes I've made on the CHANGES.md and followed actual conventions
  • I added a new section on how-to.md (optional)
    • I used ../assets/images/how-to/show-local-time.png?raw=true for my documentation reference images. If something like https://github.com/tprouvot/Salesforce-Inspector-reloaded/assets/{ID}/{UUID} is more appropriate, please provide instructions and I'll get this updated.

Notes

  • the offsetMinutes calculations and time reshuffling is necessary to accommodate 30 and 45 minute offsets for time zones.
  • time conversion is disabled by default to avoid disrupting workflows.

@dmoruzzi dmoruzzi changed the title Local browser time option for Data Export [data-export] Local browser time config option Nov 29, 2024
@dmoruzzi
Copy link
Author

Partially related to #496. I felt a toggle for all was more meaningful as it allowed me to quickly compare multiple rows at the same time.

@tprouvot
Copy link
Owner

Thanks for the PR @dmoruzzi, I'll check this in details but looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants