receiver: re-apply directory timestamps after copying #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Nov 8, 2022
This is needed as creating files in directories modifies their timestamp, so we need to set the timestamp again after creating all the directory contents. This logic is similar to the logic in diffapply_unix.go in moby/buildkit. Signed-off-by: Justin Chadwell <[email protected]>
jedevc
force-pushed
the
receiver-directory-timestamps
branch
from
c7a2672
to
408d4a2
Compare
|
Added a regression test. |
tonistiigi
approved these changes
Nov 10, 2022
|
Added follow-up in #141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes the bug reported in moby/buildkit#2884 (comment).
This is needed as creating files in directories modifies their timestamp, so we need to set the timestamp again after creating all the directory contents.
This logic is similar to the logic in diffapply_unix.go in moby/buildkit.