-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from STL #58
Open
mxndrwgrdnr
wants to merge
16
commits into
tomtom-international:master
Choose a base branch
from
mxndrwgrdnr:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from STL #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stl changes
Signed-off-by: Max Gardner <[email protected]>
bug fix, equal area for matched route
convert generators to lists in order to use caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up here from my discussion with @davidniedzielski-tomtom.
Over the course of implementing a version of the OpenLR Python decoder for Streetlight Data, I made some changes that I thought might qualify as improvements, and that I thought might be worth contributing back to the project. All changes should be non-destructive or at least backwards compatible. In general the changes can be grouped into a few categories which I summarize here. From most to least important:
a) timeout for line decoding (default 50,000 s)
b) equal-area SRID (default is 9311)
c) equal-area flag (default is
False
)I appreciate the fact that the purpose of this repo was NOT for the code to be super performant, but instead simple and readable. While I don't think any of the changes I've proposed here are very complex, they were designed to improve performance rather than readability, so I understand if they are not all deemed to be appropriate for a PR.