Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from STL #58

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

mxndrwgrdnr
Copy link

@mxndrwgrdnr mxndrwgrdnr commented Nov 29, 2023

Following up here from my discussion with @davidniedzielski-tomtom.

Over the course of implementing a version of the OpenLR Python decoder for Streetlight Data, I made some changes that I thought might qualify as improvements, and that I thought might be worth contributing back to the project. All changes should be non-destructive or at least backwards compatible. In general the changes can be grouped into a few categories which I summarize here. From most to least important:

  1. postgres map reader and primitives
  2. optimize decoder to handle spatial inputs (segments + basemap) stored in equal-area projection
  3. new configs
    a) timeout for line decoding (default 50,000 s)
    b) equal-area SRID (default is 9311)
    c) equal-area flag (default is False)
  4. object attribute caching and optimization to limit calls to db
  5. auto-formatting <-- I can undo these changes if preferred, I had Python Black enabled when I made these changes so it auto-formatted things like line breaks, etc.

I appreciate the fact that the purpose of this repo was NOT for the code to be super performant, but instead simple and readable. While I don't think any of the changes I've proposed here are very complex, they were designed to improve performance rather than readability, so I understand if they are not all deemed to be appropriate for a PR.

@mxndrwgrdnr mxndrwgrdnr marked this pull request as ready for review November 30, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant