Formatting/tests

[VascoSch92]

Sorry, I closed the old PR an di opened a new one ;-)

Ps: the tests are failing not bevause of my code. But i will correct that ;) when i have time

[VascoSch92]

There are errors because pyflake8 doesn't like when the symbol \ is in the doctoring of a method

[VascoSch92]

@tommyod Hey 👋 what do you think?

[tommyod]

Hi! The logs have expired, the the tests did not pass. I am not sure you why. Could you push a new commit to re-trigger so we get logs and can figure out why tests fail? We need everything to pass before merging.

As for the PR itself I have not looked at it in detail yet. Will do it once tests pass! Here you wrote that you wanted to use pytest, which seems like a good idea. However, in the PR you also remove some docstrings, change latex notation (e.g. Z_n instead of \mathbb{Z}_n), etc. If you want to do this, you should (1) explain why and (2) do it in a separate PR.

Still happy to merge this, but (1) lets get tests to pass and (2) please remove anything not related to pytest from this PR (you can move the changes to those files a different branch in git). Keeping PRs related to one issue at a time makes them easier to review.

[VascoSch92]

Hi! The logs have expired, the the tests did not pass. I am not sure you why. Could you push a new commit to re-trigger so we get logs and can figure out why tests fail? We need everything to pass before merging.

As for the PR itself I have not looked at it in detail yet. Will do it once tests pass! Here you wrote that you wanted to use pytest, which seems like a good idea. However, in the PR you also remove some docstrings, change latex notation (e.g. Z_n instead of \mathbb{Z}_n), etc. If you want to do this, you should (1) explain why and (2) do it in a separate PR.

Still happy to merge this, but (1) lets get tests to pass and (2) please remove anything not related to pytest from this PR (you can move the changes to those files a different branch in git). Keeping PRs related to one issue at a time makes them easier to ...

The problem with the docstring is described in the comment above. But perhaps is also something other. I wanted also to look at the logs ;)

I can trigger the tests with a new commit (i cannot re-run the workflows myself) and i will give a closer look. Then we can decide according.😉

[tommyod]

Sounds good! I found this and this when googling. See if it fixes the problem!