Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gfm-add-toc.user.js #2

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Conversation

kgashok
Copy link

@kgashok kgashok commented Jul 19, 2017

  • added missing semicolon;
  • removed unnecessary spaces to format TOC properly.

added missing semicolon; removed unnecessary spaces to format TOC properly.
- Replaced **href** with **button** element; still some more styling to be done
- commented out the setTimeOut. Why is there? 
- added the right button style 
- ToC now appears before h1
Resolved #1 for Firefox usage by reintroducing the setTimeOut code
Firefox not working, commenting out the timeOut again.
Included "Edit File" button for error prompts.
- Using querySelector (more widely supported versus getElementsByClassName) 
- changed the ToC styling to match Edit button
folded back the more detailed error prompts.
Double quotation error fixed.
removed stackedit.io related code for now.
@kgashok
Copy link
Author

kgashok commented Jul 24, 2017

Resolved #5 with a presentation issue kgashok#6 that needs to be resolved.

Refactored code to be self documented.
trying to fix firefox disabling.
Refactored to remove an 'if' - have to make sure it doesn't break Firefox
One more refactor - need to check Firefox
Re-introduced the setTimeout to re-enable the ToC button on Firefox
@kgashok
Copy link
Author

kgashok commented Jul 24, 2017

Resolved #1 on both Chrome and Firefox, and appears consistently before the h1 button

@dscho
Copy link
Contributor

dscho commented Aug 4, 2017

Whoa, you've been busy!

Problem is: I now work on Git for Windows pretty much full time and do not have the time to take care of this project properly anymore. Also, nobody else in the tomancaklab seems to be willing (or for that matter, competent) enough to take custody of this user script.

How about we move it into your personal account, and I fork it here with a note that you took over maintenance?

@dscho
Copy link
Contributor

dscho commented Aug 4, 2017

How about we move it into your personal account, and I fork it here with a note that you took over maintenance?

And since this here repository hosts https://tomancaklab.github.io/, what I meant, really, was that you start a new repository called, say, gfm-add-toc.user.js, and I adjust the links here, and merge back your work?

@kgashok
Copy link
Author

kgashok commented Aug 4, 2017

Sure, I don't mind. But I have never done this kind of "transfer". So do let me know the detailed steps.

@dscho
Copy link
Contributor

dscho commented Oct 23, 2017

So do let me know the detailed steps.

Sorry, I thought I laid it out in #2 (comment). Basically, you would start a new repository on GitHub, clone it, call git pull https://github.com/kgashok/tomancaklab.github.io master and then push to your new repository. Then you'd tell me about it and I would then merge your work into this repository, and whenever you have new things, you prod me again and I'll merge again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants