Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: sql null column error #234

Merged
merged 6 commits into from
Aug 11, 2023
Merged

bugfix: sql null column error #234

merged 6 commits into from
Aug 11, 2023

Conversation

felixgunawan
Copy link
Contributor

@felixgunawan felixgunawan commented Aug 5, 2023 •
edited
Loading

Currently when using sql chain on tables with nullable columns, it will return converting null to string error is not supported. To mitigate this issue, I'm suggesting to use sql.NullString to handle null values.
Fixes #235

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@felixgunawan felixgunawan mentioned this pull request Aug 5, 2023
Closed
@felixgunawan felixgunawan changed the title fix null column error bugfix: null column error Aug 5, 2023
@felixgunawan felixgunawan changed the title bugfix: null column error bugfix: sql null column error Aug 5, 2023
zivkovicn
zivkovicn reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@zivkovicn zivkovicn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add the test for this?

@felixgunawan
Copy link
Contributor Author

done @zivkovicn , please help to review again

@zivkovicn
Copy link
Contributor

@felixgunawan I'm ass well waiting for the PR to be merged (#177) hopefully @tmc will do it as soon as possible 😄

@tmc tmc merged commit 4d6b7ab into tmc:main Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicn zivkovicn zivkovicn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sql error : converting NULL to string is unsupported
3 participants
@felixgunawan @zivkovicn @tmc