Chroma: Replace existing documents with newer versions #1058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am planing to index our confluence wiki with go langchain.
Therefore I had to be able to replace existing documents in chroma.
This needed the following changes:
vectorstores.WithIDGenerater
option and the accordingGenerateDocumentID
func defaulting touuid.NewString()
GenerateDocumentID
func in chroma (and implemented to the best of my abilites for the rest of the stores).While at it I realised that the chroma vectorstore did not call the
Deduplicater
so I fixed this as well.PR Checklist
memory: add interfaces for X, Y
orutil: add whizzbang helpers
).Fixes #123
).golangci-lint
checks.