add unit test for bugfix sql nullable column error

tmc · Aug 7, 2023 · 28d4ec1 · 28d4ec1
1 parent 95dedae
commit 28d4ec1
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 0 deletions.
diff --git a/tools/sqldatabase/mysql/mysql_test.go b/tools/sqldatabase/mysql/mysql_test.go
@@ -2,6 +2,8 @@ package mysql_test
 
 import (
 	"context"
+	"database/sql"
+	"fmt"
 	"os"
 	"testing"
 
@@ -28,4 +30,12 @@ func Test(t *testing.T) {
 	require.NoError(t, err)
 
 	t.Log(desc)
+
+	for _, tableName := range tbs {
+		_, err = db.Query(context.Background(), fmt.Sprintf("SELECT * from %s LIMIT 1", tableName))
+		if err == sql.ErrNoRows { // exclude no row error, since we only need to check if db.Query function can perform query correctly
+			continue
+		}
+		require.NoError(t, err)
+	}
 }
diff --git a/tools/sqldatabase/postgresql/postgresql_test.go b/tools/sqldatabase/postgresql/postgresql_test.go
@@ -2,6 +2,8 @@ package postgresql_test
 
 import (
 	"context"
+	"database/sql"
+	"fmt"
 	"os"
 	"testing"
 
@@ -27,4 +29,13 @@ func Test(t *testing.T) {
 	require.NoError(t, err)
 
 	t.Log(desc)
+
+	for _, tableName := range tbs {
+		_, err = db.Query(context.Background(), fmt.Sprintf("SELECT * from %s LIMIT 1", tableName))
+		if err == sql.ErrNoRows { // exclude no row error, since we only need to check if db.Query function can perform query correctly
+			continue
+		}
+		require.NoError(t, err)
+	}
+
 }
diff --git a/tools/sqldatabase/sqlite3/sqlite3_test.go b/tools/sqldatabase/sqlite3/sqlite3_test.go
@@ -3,6 +3,7 @@ package sqlite3_test
 import (
 	"context"
 	"database/sql"
+	"fmt"
 	"os"
 	"strings"
 	"testing"
@@ -46,4 +47,12 @@ func Test(t *testing.T) {
 	require.True(t, strings.Contains(desc, "Activity"))       //nolint:stylecheck
 	require.True(t, strings.Contains(desc, "Activity1"))      //nolint:stylecheck
 	require.True(t, strings.Contains(desc, "Activity2"))      //nolint:stylecheck
+
+	for _, tableName := range tbs {
+		_, err = db.Query(context.Background(), fmt.Sprintf("SELECT * from %s LIMIT 1", tableName))
+		if err == sql.ErrNoRows { // exclude no row error, since we only need to check if db.Query function can perform query correctly
+			continue
+		}
+		require.NoError(t, err)
+	}
 }