Initial support for TLAPS. #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@afonsonf I believe this question is more up your alley?! |
|
I will take a look |
afonsonf
reviewed
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a draft. The code is there, but it fails to start. I'm out of ideas for fixing this. The plugin fails now with
The same language client ("vscode-languageclient": "=9.0.0") works in https://github.com/kape1395/tlapm/tree/lsp/lsp/test/tlapm-lsp-test, but here it fails to start. My local vscode version is
1.83.1. It should match the^1.82.0pattern but fails to do that. I fixed the exact version to match the one I used for the LSP tests, but that doesn't help.You can test it by changing the setting
tlaplus.tlaps.enabledto true. The tlapm is not even needed, as the failure happens before trying to call it. @lemmy , any ideas would be appreciated.