Enable check model command from model checking panel #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
lemmy
force-pushed
the
master
branch
2 times, most recently
from
0cf55d7
to
193c979
Compare
When the model pane is active, the last checked model is used as the model to check. This is needed since the spec to check is otherwise retrieved using the active file. Since there is no active file if the model pane is active, we need to supply another file to check. This commit also refactors several checkModel helper functions to return Result types. This allows for errors to be propagated back and potentially ignored rather than immediately resulting in an error message.
Instead the canRunTlc check is now performed just before TLC is executed. This avoids code duplication while only sacrificing a bit of early warning.
The match statement works well, but makes the code a little hard to read. Refactoring in favor of longer conditional statements makes the code more readable
klinvill
force-pushed
the
klinvill/enable-check-model-from-panel
branch
from
f3b3541
to
6582c3e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
The work as part of #242 identified/created the problem that the code can check another specification than what the HTML page shows. |
lemmy
force-pushed
the
master
branch
2 times, most recently
from
2e22ed0
to
46ef234
Compare
lemmy
force-pushed
the
master
branch
10 times, most recently
from
2866e79
to
069d5c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #215, replaces #216.
This PR extends the
tlaplus.model.check.runcommand to be enabled whenevertlaplus.tlc.canRunAgainis true. This has the effect of showing the check model command when the model checking pane is active. When no TLA+ file is active, the command falls back on using the last checked spec. The flow of the checkModel function roughly follows:This PR also refactors the helper functions called by checkModel to return
Resulttypes. Returning a Result allows the error messages to be ignored in the case where a TLA+ file is not active but the last checked spec is known and can be used.As part of the refactoring, I also extracted the
canRunTlc()checks from functions that get the editor and moved them to the functions that run the TLC tool (doCheckModel()anddoEvaluateExpression()).