-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proof of concept Model Editor web view #152
base: master
Are you sure you want to change the base?
Conversation
- In the most simple of model checking cases, this works now; PoC finshed to a point to ping mku. - Minor clean-up and a few comments before making a PR, per mku request.
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
@@ -25,6 +26,7 @@ const TLAPLUS_CFG_FILE_SELECTOR: vscode.DocumentSelector = { scheme: 'file', lan | |||
const CHANGELOG_URL = vscode.Uri.parse('https://github.com/alygin/vscode-tlaplus/blob/master/CHANGELOG.md#change-log'); | |||
|
|||
const tlaDocInfos = new TlaDocumentInfos(); | |||
export const symbolsProvider = new TlaDocumentSymbolsProvider(tlaDocInfos); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this doesn't break anything, it did end up being a change that I no longer needed; this and the change at line 88/93.
@quaeler, thanks for putting your effort into adding this feature to the extension! And sorry for the late reply, things have been a bit disrupted recently. As a PoC it looks good. But before moving further, I'd like us to come up with a vision of what features this editor should support. My main concerns are:
What features do you think this editor should have when it's ready for publishing? cc @lemmy |
The biggest concern about the lack of a model editor is the missing separation between the spec and models, which causes users to write specs that are tailored to TLC model checking. For example, an Init predicate is specified as To encourage users to separation the model from the spec, the VSCode extension should thus support definition overrides, state & action constraints, ... somehow; either with an interactive UI or - if it better aligns with the VSCode best practices - a text-based interface. A low-hanging fruit might be - for the vanilla extension - to generate not only a .cfg file automatically, but also a .tla file (similar to what the Toolbox does). |
(It is generating those files) |
The Twitter thread ending with https://twitter.com/miguelraz_/status/1336892757885865985 shows how the lack of a model editor is a usability impediment (especially for learners). |
a7b46cb
to
21f4ef7
Compare
FWIW: The model-checking results web-view doesn't work (not shared) when live-sharing with VSCode. |
0cf55d7
to
193c979
Compare
2e22ed0
to
46ef234
Compare
2866e79
to
069d5c4
Compare
This is an experimental addition (a rough proof of concept) of introducing a Toolbox-esque Model Editor into the VS Code extension.