Majority #93
Merged
Majority #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: merz <[email protected]>
Signed-off-by: merz <[email protected]>
Signed-off-by: merz <[email protected]>
Signed-off-by: merz <[email protected]>
|
LGTM, but do you want the TLAPS.tla module to be checked in as well? |
|
If it can be avoided, I’d rather leave it out but looking at other entries I got the impression that it needed to be present in order to avoid CI error messages?On 4 Sep 2023, at 20:37, Markus Alexander Kuppe ***@***.***> wrote:
LGTM, but do you want the TLAPS.tla module to be checked in as well?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Signed-off-by: merz <[email protected]>
^^ @ahelwer |
|
So I removed the TLAPS module (from the repo and from manifest.json) and everything seems to work. Unless @ahelwer sees a reason for including the module, I think this is good to merge. |
|
@lemmy I recall I had deleted all the TLAPS.tla files in the big TLAPS CI PR but you wanted those changes reverted, don't remember why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new beginner-friendly TLA+ spec for an efficient majority vote algorithm due to Boyer and Moore. Comes with a model suitable for TLC and a proof that can be checked using TLAPS.