#1497 fix error message when all assignments are graded (#1534)

tl-its-umich-edu · Sep 13, 2023 · 8204866 · 8204866
1 parent c156cf8
commit 8204866
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 15 deletions.
diff --git a/assets/src/components/AssignmentGoalInput.js b/assets/src/components/AssignmentGoalInput.js
@@ -76,16 +76,14 @@ function AssignmentGoalInput (props) {
         variant='outlined'
         style={{ marginRight: '10px', width: '25ch' }}
       />
-      {
-        <Button
-          variant='contained'
-          className={classes.clearButton}
-          onClick={handleClearGoalGrades}
-          aria-label='clear'
-        >
-          Clear
-        </Button>
-      }
+      <Button
+        variant='contained'
+        className={classes.clearButton}
+        onClick={handleClearGoalGrades}
+        aria-label='clear'
+      >
+        Clear
+      </Button>
     </Grid>
   )
 }

diff --git a/assets/src/containers/AssignmentPlanningV2.js b/assets/src/containers/AssignmentPlanningV2.js
@@ -257,8 +257,7 @@ function AssignmentPlanningV2 (props) {
                         handleInputFocus={handleInputFocus}
                         handleInputBlur={handleInputBlur}
                       />
-                    </div>
-                  )
+                    </div>)
               }
               <UserSettingSnackbar
                 saved={!mutationError && !mutationLoading && settingChanged}

diff --git a/assets/src/hooks/useMathWarning.js b/assets/src/hooks/useMathWarning.js
@@ -1,13 +1,13 @@
 import { useEffect, useState } from 'react'
 
-const allAssignmentsAreGradedOrHasGoalGrade = assignments =>
-  assignments.filter(a => !(a.graded || a.goalGradeSetByUser)).length === 0
+const allAssignmentsHasGoalGrade = assignments =>
+  assignments.filter(a => !(a.goalGradeSetByUser)).length === 0
 
 const useMathWarning = assignments => {
   const [showMathWarning, setShowMathWarning] = useState(false)
 
   useEffect(() => {
-    if (allAssignmentsAreGradedOrHasGoalGrade(assignments)) {
+    if (allAssignmentsHasGoalGrade(assignments)) {
       setShowMathWarning(true)
     } else {
       setShowMathWarning(false)