Improvements to LDAP extension, with nickname support and meaningful error messages #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will also fix #39 issue. |
…ismatch extraction from language pack.
…ersion to change between 2 or 3 using Settings
|
Implemented multiple LDAP domain settings, overhaul settings to display settings into sections. Added select2 to handle dropdown and multiple selection, pre-register LDAP fields options for easier usability. |
Remove Mithril generated option list, use select2 data instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Nickname support, with the ability to use any search field that is set within settings.
Please note That Nicknames extension must be enabled to be able to save Nicknames, placeholder will display givenname,sn as a example which is 'First Name' 'Surname' to be set as the Nickname for user profile
Added LDAP error messages for users, instead of the 'Error has occurred' html response. This will fix #48 issue.
Added Setting to allow admin's to display detail errors or not, this is a toggle in settings:
Detailed error response will display incorrect LDAP binding:
Detailed error response will display if LDAP search for account exist:
Detailed error response will display if LDAP account password is incorrect:
