Add hypercore chunk tests for triggers #7483
Open
+372
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for statement and row triggers on hypercore chunks. We test `INSERT`, `UPDATE`, `DELETE`, and `TRUNCATE` triggers, where applicable. We check that the `OLD` and `NEW` values are correct as well as that the statement and row triggers are executed the correct number of times.
mkindahl
force-pushed
the
hypercore-test-triggers
branch
from
1a7f4b1
to
1510ded
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7483 +/- ##
==========================================
+ Coverage 80.06% 82.12% +2.06%
==========================================
Files 190 230 +40
Lines 37181 43129 +5948
Branches 9450 10846 +1396
==========================================
+ Hits 29770 35421 +5651
- Misses 2997 3388 +391
+ Partials 4414 4320 -94 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
@gayyappan, @erimatnor: please review this pull request.
|
Comment on lines
+10
to
+30
| create function save_insert_row() returns trigger as $$ | ||
| begin | ||
| insert into saved_rows select new.*, true, 'insert'; | ||
| return new; | ||
| end; | ||
| $$ language plpgsql; | ||
|
|
||
| create function save_update_row() returns trigger as $$ | ||
| begin | ||
| insert into saved_rows select new.*, true, 'update'; | ||
| insert into saved_rows select old.*, false, 'update'; | ||
| return new; | ||
| end; | ||
| $$ language plpgsql; | ||
|
|
||
| create function save_delete_row() returns trigger as $$ | ||
| begin | ||
| insert into saved_rows select old.*, false, 'delete'; | ||
| return new; | ||
| end; | ||
| $$ language plpgsql; |
There was a problem hiding this comment.
I think it can be simplified in only one trigger function and also track TG_WHEN and use TG_OP to save the proper operation on the saved_rows table.
Another thing is that you're testing only BEFORE triggers and what about AFTER and INSTEAD OF ??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for statement and row triggers on hypercore chunks. We test
INSERT,UPDATE,DELETE, andTRUNCATEtriggers, where applicable. We check that theOLDandNEWvalues are correct as well as that the statement and row triggers are executed the correct number of times.Disable-check: force-changelog-file