Use brief explain stats #7355
Open
Use brief explain stats #7355
+578
−598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7355 +/- ##
==========================================
+ Coverage 80.06% 82.09% +2.03%
==========================================
Files 190 230 +40
Lines 37181 43145 +5964
Branches 9450 10853 +1403
==========================================
+ Hits 29770 35422 +5652
- Misses 2997 3397 +400
+ Partials 4414 4326 -88 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
mkindahl
force-pushed
the
hypercore-brief-array-stats
branch
2 times, most recently
from
bf29758
to
8f68c55
Compare
mkindahl
force-pushed
the
hypercore-brief-array-stats
branch
from
8f68c55
to
dbf3262
Compare
mkindahl
force-pushed
the
hypercore-brief-array-stats
branch
2 times, most recently
from
4d48cfb
to
8262b48
Compare
Comment on lines
+101
to
+115
| ExplainOpenGroup("Array Cache", "Arrow Array Cache", true, es); | ||
| ExplainPropertyInteger("hits", NULL, decompress_cache_stats.hits, es); | ||
| ExplainPropertyInteger("misses", NULL, decompress_cache_stats.misses, es); | ||
| ExplainPropertyInteger("evictions", NULL, decompress_cache_stats.evictions, es); | ||
| ExplainCloseGroup("Array Cache", "Arrow Array Cache", true, es); | ||
|
|
||
| ExplainOpenGroup("Array Decompress", "Arrow Array Decompress", true, es); | ||
| ExplainPropertyInteger("count", NULL, decompress_cache_stats.decompressions, es); | ||
| if (es->verbose) | ||
| ExplainPropertyInteger("calls", | ||
| NULL, | ||
| decompress_cache_stats.decompress_calls, | ||
| es); | ||
| ExplainCloseGroup("Array Decompress", "Arrow Array Decompress", true, es); | ||
| } |
There was a problem hiding this comment.
We need to add tests for other EXPLAIN output format than TEXT
There was a problem hiding this comment.
Added one for JSON, which should get better coverage here.
There was a problem hiding this comment.
Looks like we also need to test using VERBOSE on the explain to fully cover the code paths
mkindahl
force-pushed
the
hypercore-brief-array-stats
branch
from
75c2c10
to
cf8ce07
Compare
Use a more compact and easy to read version for the decompression and arrow array cache stats. Also simplify the code and the tests to remove unnecessary parts.
mkindahl
force-pushed
the
hypercore-brief-array-stats
branch
from
cf8ce07
to
675f2f4
Compare
| if (has_decompress_data) | ||
| appendStringInfoString(es->str, ", decompress"); | ||
| append_if_positive(es->str, "count", decompress_cache_stats.decompressions); | ||
| append_if_positive(es->str, "calls", decompress_cache_stats.decompress_calls); |
There was a problem hiding this comment.
Shouldn't this calls be added only when es->verbose==true like in non-text format?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a more compact and easy to read version for the decompression and arrow array cache stats and simplify the code.
Disable-check: force-changelog-file