fix: allow members of source table to create vectorizer #254
+50
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGuthrie
force-pushed
the
jg/fix-non-owner-create-vectorizer
branch
from
b9d68d3
to
b8ead49
Compare
adolsalamanca
approved these changes
Nov 26, 2024
| -- don't let anyone but the owner of the source table call this | ||
| select k.relowner operator(pg_catalog.=) pg_catalog.session_user()::pg_catalog.regrole | ||
| -- don't let anyone but the owner (or members of the owner's role) of the source table call this | ||
| select pg_catalog.pg_has_role(_vectorizer_create_dependencies.caller, k.relowner, 'MEMBER') |
There was a problem hiding this comment.
weird attribute qualification (_vectorizer_create_dependencies.caller instead of just caller), why?
| drop function if exists ai._vectorizer_create_dependencies(integer); | ||
|
|
||
| -- https://stackoverflow.com/a/42011279 | ||
| create domain whoami as name |
There was a problem hiding this comment.
don't we want to schema qualify it as well?
alexeyklyukin
approved these changes
Nov 26, 2024
JamesGuthrie
force-pushed
the
jg/fix-non-owner-create-vectorizer
branch
2 times, most recently
from
1b1c839
to
bdc11b5
Compare
JamesGuthrie
force-pushed
the
jg/fix-non-owner-create-vectorizer
branch
from
bdc11b5
to
12082d3
Compare
cevian
reviewed
Nov 26, 2024
| @@ -0,0 +1 @@ | |||
| drop function if exists ai._vectorizer_create_dependencies(integer); | |||
There was a problem hiding this comment.
doh - we don't. It was a stray leftover from before I removed some other bits.
In f68e73a we added support for cascading the source/target table drop to the queue and other dependent objects. In adding this, we added a security definer function which asserts that the owner of the source table is calling the security definer function. Due to how security definer functions work with `current_user`, the ownership check opted to use `session_user` to check ownership. This is problematic because in connections which use `SET ROLE`, the `session_user` may not be the same as `current_user`. This commit relaxes the ownership check to check whether the current user is a member of the role that owns the source table.
JamesGuthrie
force-pushed
the
jg/fix-non-owner-create-vectorizer
branch
from
12082d3
to
a0fa061
Compare
cevian
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In f68e73a we added support for cascading the source/target table drop to the queue and other dependent objects. In adding this, we added a security definer function which asserts that the owner of the source table is calling the security definer function.
Due to how security definer functions work with
current_user, the ownership check opted to usesession_userto check ownership. This is problematic because in connections which useSET ROLE, thesession_usermay not be the same ascurrent_user.This commit relaxes the ownership check to check whether the current
user is a member of the role that owns the source table.