-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use monorepo structure #101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandrodnm
force-pushed
the
adn/monorepo
branch
9 times, most recently
from
October 9, 2024 18:03
0ade028
to
e4cf75b
Compare
alejandrodnm
force-pushed
the
adn/monorepo
branch
2 times, most recently
from
October 9, 2024 19:04
e4cf75b
to
43cf52f
Compare
alejandrodnm
force-pushed
the
adn/monorepo
branch
2 times, most recently
from
October 9, 2024 22:10
27b2fb7
to
7a07ebe
Compare
alejandrodnm
force-pushed
the
adn/monorepo
branch
from
October 9, 2024 22:32
7a07ebe
to
efc3076
Compare
alejandrodnm
requested review from
jgpruitt,
cevian,
avthars and
a team
as code owners
October 10, 2024 09:36
jgpruitt
added a commit
that referenced
this pull request
Oct 24, 2024
refactor: use monorepo structure * refactor: update .gitignore paths * refactor: path fixes and clarifications in build.py * chore: fix formatting in extension tests * refactor: update paths in test_contents * refactor: update paths in test_dump_restore * refactor: update paths in test_privileges * refactor: update paths in test_cli * fix: format sql identifiers in test_vectorizer * refactor: calc vcr cassette dir * refactor: use single tiktoken_cache across tests * fix: handle when tictoken_cache is str in cli * chore: fix formating and reenable ci check * chore: run ci vectorizer tests not in docker --------- Co-authored-by: John Pruitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of how it would look like.
I include the lambda_handler, since we might want to expose that to customers as well, and because all the existing tests were targeting the lambda handler. We could move it to examples if we don't want it here.
I didn't exhaustively looked into the
build.py
script, there might be some broken things there. I also just added commands to the Makefile directly.