Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce comparison expressions #330

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

introduce comparison expressions #330

wants to merge 24 commits into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Nov 10, 2024

Extended version of #270, with joins.

@krlmlr krlmlr marked this pull request as draft November 10, 2024 10:10
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 308ce26 is merged into main:

  • ✔️001_tpch_01: 24.1ms -> 23.4ms [-6.68%, +0.48%]
  • ✔️001_tpch_02: 124ms -> 123ms [-2.12%, +0.4%]
  • ✔️001_tpch_03: 65.6ms -> 65.1ms [-3.88%, +2.35%]
  • 🚀001_tpch_04: 23.6ms -> 22.8ms [-4.02%, -2.11%]
  • ✔️001_tpch_05: 120ms -> 120ms [-2.18%, +1.05%]
  • 🚀001_tpch_06: 15.1ms -> 14.6ms [-5.05%, -0.36%]
  • 🚀001_tpch_07: 139ms -> 135ms [-4.84%, -1.57%]
  • 🚀001_tpch_08: 161ms -> 158ms [-2.57%, -0.77%]
  • ✔️001_tpch_09: 134ms -> 133ms [-1.98%, +0.78%]
  • 🚀001_tpch_10: 74.5ms -> 72.8ms [-4%, -0.48%]
  • ✔️001_tpch_11: 60.9ms -> 60.3ms [-2.15%, +0.23%]
  • ❗🐌001_tpch_12: 28.8ms -> 57.2ms [+93.4%, +103.6%]
  • ✔️001_tpch_13: 19.6ms -> 19.6ms [-2.05%, +1.77%]
  • 🚀001_tpch_14: 21ms -> 20.6ms [-3.29%, -0.89%]
  • ✔️001_tpch_15: 63.1ms -> 62.7ms [-2.93%, +1.68%]
  • ✔️001_tpch_16: 63.8ms -> 63.4ms [-1.88%, +0.78%]
  • ✔️001_tpch_17: 28ms -> 27.7ms [-4.29%, +2.13%]
  • ✔️001_tpch_18: 25.1ms -> 24.6ms [-4.61%, +0.53%]
  • ✔️001_tpch_19: 134ms -> 133ms [-2.27%, +1.84%]
  • 🚀001_tpch_20: 80.9ms -> 78.4ms [-5.12%, -1%]
  • ✔️001_tpch_21: 183ms -> 181ms [-4.04%, +2.12%]
  • ✔️001_tpch_22: 132ms -> 131ms [-4.03%, +1.86%]
  • ✔️010_tpch_01: 84.7ms -> 82.4ms [-9%, +3.45%]
  • ✔️010_tpch_02: 72.2ms -> 73.2ms [-1.83%, +4.75%]
  • 🚀010_tpch_03: 65.5ms -> 62.1ms [-6.76%, -3.75%]
  • 🚀010_tpch_04: 49.6ms -> 44.7ms [-13.32%, -6.17%]
  • ✔️010_tpch_05: 94.4ms -> 93ms [-5.75%, +2.68%]
  • ✔️010_tpch_06: 34.8ms -> 33.6ms [-7.04%, +0.6%]
  • 🚀010_tpch_07: 113ms -> 108ms [-6.27%, -2.78%]
  • 🚀010_tpch_08: 135ms -> 128ms [-8.69%, -1.24%]
  • ✔️010_tpch_09: 116ms -> 117ms [-0.81%, +1.83%]
  • 🚀010_tpch_10: 84.7ms -> 78.4ms [-10.38%, -4.43%]
  • 🚀010_tpch_11: 38.6ms -> 37.1ms [-6.84%, -0.7%]
  • 🚀010_tpch_12: 62.7ms -> 60.7ms [-4.52%, -1.9%]
  • ✔️010_tpch_13: 53.7ms -> 53.6ms [-2.15%, +1.85%]
  • 🚀010_tpch_14: 43.8ms -> 41.4ms [-9.35%, -1.84%]
  • ✔️010_tpch_15: 58.9ms -> 55.8ms [-12.39%, +1.99%]
  • ✔️010_tpch_16: 46.9ms -> 45.4ms [-8.07%, +1.62%]
  • 🚀010_tpch_17: 57ms -> 55.3ms [-5.79%, -0.27%]
  • ✔️010_tpch_18: 58.4ms -> 56.5ms [-10.03%, +3.59%]
  • 🚀010_tpch_19: 126ms -> 118ms [-8.86%, -3.68%]
  • 🚀010_tpch_20: 72.9ms -> 69.6ms [-8.4%, -0.7%]
  • 🚀010_tpch_21: 409ms -> 373ms [-10.29%, -7.43%]
  • ✔️010_tpch_22: 76.8ms -> 77.4ms [-1.82%, +3.39%]
  • ✔️100_tpch_01: 1.19s -> 1.19s [-4.38%, +5.53%]
  • ✔️100_tpch_02: 128ms -> 134ms [-7.83%, +17.23%]
  • ✔️100_tpch_03: 1.07s -> 1.08s [-6.12%, +6.63%]
  • ✔️100_tpch_04: 1.06s -> 1.04s [-4%, +0.96%]
  • ✔️100_tpch_05: 1.17s -> 1.17s [-3.71%, +2.19%]
  • ✔️100_tpch_06: 999ms -> 993ms [-4.42%, +3.41%]
  • ✔️100_tpch_07: 1.12s -> 1.12s [-2.23%, +2.02%]
  • ✔️100_tpch_08: 1.18s -> 1.15s [-4.46%, +0.49%]
  • ✔️100_tpch_09: 1.24s -> 1.25s [-3.19%, +4.35%]
  • ✔️100_tpch_10: 1.1s -> 1.1s [-3.26%, +2.18%]
  • ✔️100_tpch_11: 94.5ms -> 87ms [-24.6%, +8.76%]
  • ✔️100_tpch_12: 1.09s -> 1.07s [-4.3%, +0.89%]
  • ✔️100_tpch_13: 331ms -> 345ms [-12.87%, +21.49%]
  • ✔️100_tpch_14: 1.01s -> 999ms [-4.76%, +1.99%]
  • ✔️100_tpch_15: 1.1s -> 1.1s [-4.91%, +3.82%]
  • ✔️100_tpch_16: 123ms -> 131ms [-12.39%, +25.7%]
  • ✔️100_tpch_17: 1.08s -> 1.06s [-4.02%, +0.19%]
  • ✔️100_tpch_18: 1.1s -> 1.1s [-6.09%, +5.88%]
  • ✔️100_tpch_19: 1.16s -> 1.18s [-0.4%, +3.96%]
  • ✔️100_tpch_20: 1.06s -> 1.06s [-0.8%, +2.48%]
  • ✔️100_tpch_21: 2.25s -> 2.22s [-5.28%, +2.52%]
  • ✔️100_tpch_22: 177ms -> 175ms [-7.56%, +5.53%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants