Skip to content

Commit

Permalink
Check revdeps
Browse files Browse the repository at this point in the history
  • Loading branch information
hadley committed Jan 16, 2023
1 parent 861b08f commit 709ce58
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 74 deletions.
23 changes: 8 additions & 15 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,23 @@

## revdepcheck results

We checked 85 reverse dependencies (76 from CRAN + 9 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
We checked 77 reverse dependencies (76 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.

* We saw 4 new problems
* We failed to check 2 packages
* We saw 2 new problems: dcmodifydb and validatedb.
The maintainer of both packages was notified several months ago and
reminded several times.

* We failed to check 0 packages

Issues with CRAN packages are summarised below.

### New problems
(This reports the first line of each new failure)

* bcdata
checking tests ...

* dcmodifydb
checking examples ... ERROR
checking tests ...

* tidyhydat
checking tests ...
checking tests ... ERROR

* validatedb
checking tests ...

### Failed to check
checking tests ... ERROR

* bigsnpr (NA)
* duckdb (NA)
3 changes: 1 addition & 2 deletions revdep/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@
|:-------|:-------|:-----|:-------|:----|
|NA |? | | | |

## New problems (3)
## New problems (2)

|package |version |error |warning |note |
|:----------|:-------|:------|:-------|:----|
|[bcdata](problems.md#bcdata)|0.3.2 |__+1__ | | |
|[dcmodifydb](problems.md#dcmodifydb)|0.3.1 |__+2__ | | |
|[validatedb](problems.md#validatedb)|0.1.4 |__+1__ | | |

7 changes: 2 additions & 5 deletions revdep/cran.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
## revdepcheck results

We checked 75 reverse dependencies (74 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
We checked 77 reverse dependencies (76 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.

* We saw 3 new problems
* We saw 2 new problems
* We failed to check 0 packages

Issues with CRAN packages are summarised below.

### New problems
(This reports the first line of each new failure)

* bcdata
checking tests ... ERROR

* dcmodifydb
checking examples ... ERROR
checking tests ... ERROR
Expand Down
66 changes: 14 additions & 52 deletions revdep/problems.md
Original file line number Diff line number Diff line change
@@ -1,41 +1,3 @@
# bcdata

<details>

* Version: 0.3.2
* GitHub: https://github.com/bcgov/bcdata
* Source code: https://github.com/cran/bcdata
* Date/Publication: 2022-07-06 07:30:02 UTC
* Number of recursive dependencies: 121

Run `revdepcheck::cloud_details(, "bcdata")` for more info

</details>

## Newly broken

* checking tests ... ERROR
```
Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
5. └─base::lapply(...)
6. └─bcdata (local) FUN(X[[i]], ...)
7. ├─rlang::new_quosure(...)
8. └─dbplyr::partial_eval(x, data = dbplyr::lazy_frame())
9. └─dbplyr::partial_eval(get_expr(call), data, get_env(call), error_call = error_call)
10. └─dbplyr:::partial_eval_call(call, data, env)
11. └─base::lapply(call[-1], partial_eval, data = data, env = env)
12. └─dbplyr (local) FUN(X[[i]], ...)
13. └─dbplyr:::partial_eval_sym(call, data, env)
14. └─cli::cli_abort("Object {.var {name}} not found.", call = NULL)
15. └─rlang::abort(...)
[ FAIL 3 | WARN 0 | SKIP 101 | PASS 63 ]
Error: Test failures
Execution halted
```

# dcmodifydb

<details>
Expand Down Expand Up @@ -82,19 +44,19 @@ Run `revdepcheck::cloud_details(, "dcmodifydb")` for more info
Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
• On CRAN (5)
══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-is_working.R:27'): is working: is working check ────────────────
Error in `dplyr::filter(table, z > 2)`: Problem while computing `..1 = z > 2`
Caused by error:
! Object `z` not found.
── Error ('test-modify.R:96'): modify: handles a non-working rule ──────────────
Error in `dplyr::filter(table, y > 1)`: Problem while computing `..1 = y > 1`
Caused by error:
! Object `y` not found.
5. │ └─purrr::map_chr(enexprs(...), escape_expr, con = con)
6. │ └─purrr:::map_("character", .x, .f, ..., .progress = .progress)
7. │ ├─purrr:::with_indexed_errors(...)
8. │ │ └─base::withCallingHandlers(...)
9. │ ├─purrr:::call_with_cleanup(...)
10. │ └─dbplyr (local) .f(.x[[i]], ...)
11. │ └─dbplyr::escape(val, con = con)
12. └─base::.handleSimpleError(...)
13. └─purrr (local) h(simpleError(msg, call))
14. └─cli::cli_abort(...)
15. └─rlang::abort(...)
[ FAIL 2 | WARN 0 | SKIP 5 | PASS 34 ]
[ FAIL 3 | WARN 0 | SKIP 5 | PASS 34 ]
Error: Test failures
Execution halted
```
Expand Down Expand Up @@ -123,12 +85,12 @@ Run `revdepcheck::cloud_details(, "validatedb")` for more info
! Object `y` not found.
── Error ('test-summary.R:32'): summary: works with failing rules ──────────────
Error in `dplyr::transmute(tbl, row = row_number(), rule = "V5", fail = !y >
0)`: Problem while computing `fail = !y > 0`
0)`: ℹ In argument: `fail = !y > 0`
Caused by error:
! Object `y` not found.
── Error ('test-summary.R:73'): summary: works with failing rules (sparse) ─────
Error in `dplyr::transmute(tbl, row = row_number(), rule = "V5", fail = !y >
0)`: Problem while computing `fail = !y > 0`
0)`: ℹ In argument: `fail = !y > 0`
Caused by error:
! Object `y` not found.
Expand Down

0 comments on commit 709ce58

Please sign in to comment.