better call routing for errors #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this one, I'll have a corresponding (but trivial) extratests PR ☝️ . |
simonpcouch
approved these changes
Oct 21, 2024
R/condense_control.R
Outdated
| "Object of class {.cls class(x)[1]} cannot be coerced to | ||
| object of class {.cls class(ref)[1]}.", | ||
| "Object of class {.cls {class(x)[1]}} cannot be coerced to | ||
| object of class {.cls {class(ref)[1]}}.", |
There was a problem hiding this comment.
Even better, I changed it to {.obj_type_friendly {x}}
| @@ -258,7 +258,7 @@ make_form_call <- function(object, env = NULL) { | |||
| } | |||
|
|
|||
| # TODO we need something to indicate that case weights are being used. | |||
| make_xy_call <- function(object, target, env) { | |||
| make_xy_call <- function(object, target, env, call = rlang::caller_env()) { | |||
There was a problem hiding this comment.
I'll just make this comment once to apply throughout the PR, but rlang is imported with @import rlang so we don't need to namespace rlang for these!
There was a problem hiding this comment.
It all comes back to psock... we started namespacing everything in these packages because importing was not enough.
Co-authored-by: Simon P. Couch <[email protected]>
topepo
added a commit
to tidymodels/extratests
that referenced
this pull request
Oct 22, 2024
Co-authored-by: ‘topepo’ <‘[email protected]’>
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focuses on functions called by user-facing functions.
A few more message conversions enabled us to remove glue from depends.
Also removed an unused function for bartMachine (which we don't support)