Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Symfony/Config Supported Versions to Include Symfony 6.0 #176

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

frankperez87
Copy link

Jira: JIRA-TOKEN

Why / What

This PR updates the Symfony/Config supported versions to include Symfony 6.0, which is required to use the latest version of Laravel 10. Laravel has a dependency on Symfony components, and by including Symfony 6.0, we ensure compatibility with the latest Laravel release.

Testing

I have tested this code by verifying that it successfully updates the Symfony/Config supported versions in the project's composer.json file and that the project still builds and runs without errors. Additionally, I interacted with the client and was able to successfully hit the Evolution API using the SDK to ensure that the update did not disrupt the functionality of the application.

Reviewer Checklist (To be edited and marked by approver)

After approving the PR, the reviewer should check the boxes below. See the Reviewer Checklist company standard for more info on these bullet points.

  • Do you understand the reasoning behind the need for the changes?
  • Given only new or existing tests*, do you feel confident that all changes work as intended and solve the problem at hand?
  • Are all success and failure paths accounted for in the tests? If not, are the omissions explained/justified?
  • If coverage ignores are present, is justification provided inline (or linked to) or is a link to a ticket to address in the future provided?
  • Are you willing to accept the same responsibility for this code as the author?

*If existing tests, requester should point out what applies

PR Code Coverage

  • Changeset: XX%
  • Overall: XX%

Measure with bin/test_cov or some other means. You can find html coverage levels in coverage/index.html or in stdout.

After a successful test run, you can also see calculated and merged coverage, per branch, on Grafana

@jwcobb
Copy link
Contributor

jwcobb commented Dec 7, 2023

@frankperez87 Can you try the 5.0.0 branch and see if that works for you? I just haven't tagged it as a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants